Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let existing scripts using pen=obese we processed correctly #4767

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

PaulWessel
Copy link
Member

Although #4766 change its name to "wide", we need to let existing scripts be processed to retain backward compatibility without discussing this in the docs.

Just checking with you all if this is OK, or if in this case a harder non-backwards-compatible change is preferred?

Although #4766 change its name to "wide", we need to let existing scripts be processed to retain backwared compatibility without discussing this in the docs.
@PaulWessel PaulWessel added this to the 6.2.0 milestone Feb 8, 2021
@PaulWessel PaulWessel self-assigned this Feb 8, 2021
Copy link
Member

@liamtoney liamtoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let others chime in on this.

@maxrjones
Copy link
Member

Given the comment description and the documentation update, I think this resolution is fine but agree that we should let anyone veto it. Just a reminder that if anyone prefers to comment about this privately, contact info for Paul and Leo are provided in the GMT code of conduct.

@joa-quim
Copy link
Member

joa-quim commented Feb 8, 2021

I confess to have troubles understanding why one call say fat pen but should not use obese pen. Furthermore, in Portuguese obese is the educated word whilst is fat that can be used in an offensive way though normally is not offensive, only if intention is put on it.

But we are talking about lines in plots, not people.

@PaulWessel
Copy link
Member Author

Yes, we are talking about lines. but obese in the Merriam-Webster dictionary says " having excessive body fat" so it is specifically about people. So I am fine with changing to "wide". I also think the resolution of allowing backwards support for anyone's script that use -Wobese be processed correctly (since we have allowed this option for years). If anyone feel we should go further and refuse to honor -Wobese then I am happy to enterain such voices either here or privately. I do not think I have ever used this one myself since I would have to look up what it is in terms of points anyway. I do -W30p etc instead.

@PaulWessel
Copy link
Member Author

I should add that I added obese just to get an even number of items in the pen table...

@liamtoney
Copy link
Member

I confess to have troubles understanding why one call say fat pen but should not use obese pen.

I actually think that fat[er|est] could be changed as well. I didn't suggest it in #4766 because I think it would break more scripts, and I think that obese is "more" inappropriate. I'm biased: I rarely, if ever, use the pen names, instead opting for e.g. -W10p (as @PaulWessel mentions).

Furthermore, in Portuguese obese is the educated word whilst is fat that can be used in an offensive way though normally is not offensive, only if intention is put on it.

I agree that in vacuum, obese is not necessarily inappropriate. I just don't believe it has a place in this context.

But we are talking about lines in plots, not people.

Yes. But people use the code, and — in particular — read the docs.

@joa-quim
Copy link
Member

joa-quim commented Feb 8, 2021

I never used -Wobese either and had no intention even before this discussion, so for me it can go. Just don't appreciate that much this route.

@PaulWessel
Copy link
Member Author

At least the "fat" name has the minor benefit of also being applied to other things than humans, eg., a fat book, fat wallet, a fat bank account.

@joa-quim
Copy link
Member

joa-quim commented Feb 8, 2021

and is often used in papers fig captions

@liamtoney
Copy link
Member

At least the "fat" name has the minor benefit of also being applied to other things than humans, eg., a fat book, fat wallet, a fat bank account.

Agreed. And the point here is not, of course, to get lost in the semantics and hair splitting. It's about being as welcoming as we can be. I feel that the proposed change as-is is a good start — we can revisit other aspects later if needed.

@PaulWessel
Copy link
Member Author

OK, that is all good. Since there is nothing left mentioning obese in usage messages or documentation or scripts we supply I think we are fine for now. Closing this issue but anyone should feel OK opening it again or a new one. Perhaps there are other aspects that can have issues too. I do remember a few years ago we got email from a student of native american ancestry who objected to the two color names Indianred and Navajowhite. I was able to show that these names are in the X11 RGB table (so not ours) and that they derive from the continent of India (indianred) and that the other has to do with the color of some characteristic pottery. However, now I an not so sure those answers that welcoming...

@PaulWessel
Copy link
Member Author

As discussed, I will close this and merge as is.

@PaulWessel PaulWessel merged commit 00c349b into master Feb 10, 2021
@PaulWessel PaulWessel deleted the backwards-wide branch February 10, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants