Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test script showing failure of clipping in TM projection #4681

Closed
wants to merge 2 commits into from

Conversation

PaulWessel
Copy link
Member

See forum for background. This PR just adds a minimal failing script to remind us to address this problem.

See forum for background.  This PR just adds a minimal failing script to remind us to address this problem,
@PaulWessel PaulWessel added the bug Something isn't working label Jan 22, 2021
@PaulWessel PaulWessel self-assigned this Jan 22, 2021
@maxrjones
Copy link
Member

Why track this with a test rather than a new issue?

@PaulWessel
Copy link
Member Author

I should certainly open an issue too. The thinking was that this is a particularly tricky problem since in this projection, it is the y-direction that has the periodic longitude boundary, so I wanted to elevate its status and make sure it is kept alive in our minds.

@PaulWessel
Copy link
Member Author

The other reason is that these types of bugs have in the past been tricky to eradicate and later code changes often reactivates such bugs. The test will then start to fail and hence notify us if that happens.

@seisman
Copy link
Member

seisman commented Jan 22, 2021

You don't provide a correct PS file for this test, so it always fails, right?

@PaulWessel
Copy link
Member Author

yes, no truth yet but I may be able to fake one soon

@maxrjones
Copy link
Member

My preference would be to use a label on the issue to elevate the status (e.g., 'priority: high') rather than a test without a postscript comparison. It should be considered a known failure, which I think could make it relatively easily forgotten. I would not be as concerned if there's a correct answer accompanying the test.

@PaulWessel
Copy link
Member Author

OK, I am fine with that - we can delete the PR if you want. I am working on the problem right now and just need to get it to work...

@PaulWessel PaulWessel closed this Jan 23, 2021
@PaulWessel PaulWessel deleted the TM-clip-failure branch January 23, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants