Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow psternary to draw lines and polygons #4433

Merged
merged 8 commits into from
Nov 8, 2020
Merged

Conversation

PaulWessel
Copy link
Member

Description of proposed changes

If -S is not given the we can plot lines or polygons. Polygons are expected if a fill (-G) or a CPT (-C) is given, else we assume lines. Polygons are plotted before the gridlines while symbols and lines are plotted after (similar to psxy). Added a simple test example to make sure it works (ternary_pol.sh).

@PaulWessel PaulWessel self-assigned this Nov 8, 2020
doc/rst/source/explain_symbols_ternary.rst_ Outdated Show resolved Hide resolved
src/psternary.c Outdated Show resolved Hide resolved
src/psternary.c Outdated Show resolved Hide resolved
test/psternary/ternary_pol.sh Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except a few typos.

@PaulWessel
Copy link
Member Author

Sorry for being a bit sloppy and thanks for finding those typos.

@PaulWessel PaulWessel merged commit 3a8a6eb into master Nov 8, 2020
@PaulWessel PaulWessel deleted the ternary-polygons branch November 8, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants