Fix typos in README.CMake #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 A few things to keep in mind:
|
joa-quim
approved these changes
Aug 27, 2018
| @@ -97,7 +97,7 @@ tests the version (gshhg_version.c). If CMake cannot find the shorelines you | |||
| have to configure _GSHHG_ROOT_ in cmake/ConfigUser.cmake. | |||
|
|
|||
| Finding DCW: | |||
| ~~~~~~~~~~~~~~ | |||
There was a problem hiding this comment.
This is allowed, but agree that it's visually unpleasant.
|
🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉 We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved. |
joa-quim
added a commit
that referenced
this pull request
Aug 27, 2018
joa-quim
added a commit
that referenced
this pull request
Aug 27, 2018
joa-quim
added a commit
that referenced
this pull request
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix typos in README.CMake