Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put the input table under the required arguments for spotter #3736

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

wangliang1989
Copy link
Contributor

@wangliang1989 wangliang1989 commented Jul 26, 2020

Description of proposed changes

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@wangliang1989 wangliang1989 changed the title WIP: put the input table under the required arguments for spotter put the input table under the required arguments for spotter Jul 26, 2020
@seisman seisman requested a review from PaulWessel July 26, 2020 22:07
Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, for grdpmodeler, the input grid is optional as you can define a region via -R -I [-r]. So it should remain in the Optional Argument section. Your other two modules are correct, so please just rever the grdpmodeler changes.

@wangliang1989
Copy link
Contributor Author

Actually, for grdpmodeler, the input grid is optional as you can define a region via -R -I [-r]. So it should remain in the Optional Argument section. Your other two modules are correct, so please just rever the grdpmodeler changes.

revered.

I think the branch is needed to rebased before merging which can be done by Github

@wangliang1989
Copy link
Contributor Author

Why not merge?

@PaulWessel
Copy link
Member

Well, our CI fails because the gmtserver is still down, but I will merge it anyway since just docs.

@PaulWessel PaulWessel merged commit 12254e3 into GenericMappingTools:master Jul 27, 2020
@PaulWessel
Copy link
Member

Thanks!

@wangliang1989
Copy link
Contributor Author

Thanks!

My another PR need your comment.

I am happy to help

@wangliang1989 wangliang1989 deleted the tabel branch July 27, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants