Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let GMT examine if the DCW file has a minimum version requirement #3703

Merged
merged 2 commits into from
Jul 22, 2020

Conversation

PaulWessel
Copy link
Member

Since DCW 1.2.0 is not compatible with GMT 6.1.0 or earlier, we have added a check in the latest GMT to see if a minimum gmt version string exists in DCW (it does from 1.2.0 onwareds) and if so determine if this GMT version passes the test.

dcw-gmt-1.2.0.tar.gz and zip are available for testing purposes in the usual pwessel/release ftp folder.

Since DCW 1.2.0 is not compatible with GMT 6.1.0 or earlier, we have added a check in the latest GMT to see if a minimum gmt version string exists in DCW (it does from 1.2.0 onwareds) and if so determine if this GMT version passes the test.
@joa-quim
Copy link
Member

As I said in the other thread, the version name must be 2.0 because it breaks compatibility.

@seisman
Copy link
Member

seisman commented Jul 22, 2020

Yes, it should be 2.0.0 if we follow semantic versions strictly.

@PaulWessel
Copy link
Member Author

You guys make me do so much work on Wednesdays...OK, will rebuild.

@PaulWessel
Copy link
Member Author

OK, files on the ftp is now 2.0.0.

ftp.soest.hawaii.edu/pwessel/release/dcw-gmt-2.0.0.tar.gz
ftp.soest.hawaii.edu/pwessel/release/dcw-gmt-2.0.0.zip

@PaulWessel PaulWessel requested a review from joa-quim July 22, 2020 18:43
@PaulWessel
Copy link
Member Author

Please install DCW 2.0.0, edut your cmake settings and rebuild master and give it a spin. Apart from generally working, you can try these

gmt coast -RZA -EZA+gred -Ggray -B -png ZAmap
gmt coast -RIT -EIT+gred -Ggray -B -pdf ITmap

If you zoom in on the ITmap you should clearly see the San Marino hole and if you zoom all in you will see a tiny hole in Rome for the Vatican.

@PaulWessel
Copy link
Member Author

And right now I cannot make it work for me... I think all I did was to change the version number. And building this branch, but let me try to figure this out first [middle of GMTSAR short course...]

@joa-quim
Copy link
Member

Yep, not working for me neither.

@PaulWessel
Copy link
Member Author

Very odd, worked fine last night... So yet another debug effort.

@PaulWessel
Copy link
Member Author

I ahve too many noncommitted branches. This one adds the check but it is not the one that makes plots.

@PaulWessel
Copy link
Member Author

OK, so this branch only adds the checking so makes no difference since the test passes. This is just for future checking of minimum GMT version required to use a particular DCW version.

@PaulWessel
Copy link
Member Author

And after merging the other branch now this one works as advertised.

@joa-quim
Copy link
Member

OM, it works for me too but you need to set the backports

@PaulWessel
Copy link
Member Author

Hm, did not set backport on the first one. @seisman how do we handle this if I backport this one?

@PaulWessel PaulWessel added the backport 6.1 Backport this PR to 6.1 branch label Jul 22, 2020
@PaulWessel
Copy link
Member Author

Ok the first has now been safely backported and this one has been labeled.

@PaulWessel PaulWessel merged commit e842216 into master Jul 22, 2020
@PaulWessel PaulWessel deleted the dcw-verson-check branch July 22, 2020 21:37
github-actions bot pushed a commit that referenced this pull request Jul 22, 2020
)

Since DCW 1.2.0 is not compatible with GMT 6.1.0 or earlier, we have added a check in the latest GMT to see if a minimum gmt version string exists in DCW (it does from 1.2.0 onwareds) and if so determine if this GMT version passes the test.
seisman pushed a commit that referenced this pull request Jul 23, 2020
) (#3708)

Since DCW 1.2.0 is not compatible with GMT 6.1.0 or earlier, we have added a check in the latest GMT to see if a minimum gmt version string exists in DCW (it does from 1.2.0 onwareds) and if so determine if this GMT version passes the test.

Co-authored-by: Paul Wessel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 6.1 Backport this PR to 6.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants