-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let GMT examine if the DCW file has a minimum version requirement #3703
Conversation
Since DCW 1.2.0 is not compatible with GMT 6.1.0 or earlier, we have added a check in the latest GMT to see if a minimum gmt version string exists in DCW (it does from 1.2.0 onwareds) and if so determine if this GMT version passes the test.
As I said in the other thread, the version name must be 2.0 because it breaks compatibility. |
Yes, it should be 2.0.0 if we follow semantic versions strictly. |
You guys make me do so much work on Wednesdays...OK, will rebuild. |
OK, files on the ftp is now 2.0.0. ftp.soest.hawaii.edu/pwessel/release/dcw-gmt-2.0.0.tar.gz |
Please install DCW 2.0.0, edut your cmake settings and rebuild master and give it a spin. Apart from generally working, you can try these
If you zoom in on the ITmap you should clearly see the San Marino hole and if you zoom all in you will see a tiny hole in Rome for the Vatican. |
And right now I cannot make it work for me... I think all I did was to change the version number. And building this branch, but let me try to figure this out first [middle of GMTSAR short course...] |
Yep, not working for me neither. |
Very odd, worked fine last night... So yet another debug effort. |
I ahve too many noncommitted branches. This one adds the check but it is not the one that makes plots. |
OK, so this branch only adds the checking so makes no difference since the test passes. This is just for future checking of minimum GMT version required to use a particular DCW version. |
And after merging the other branch now this one works as advertised. |
OM, it works for me too but you need to set the backports |
Hm, did not set backport on the first one. @seisman how do we handle this if I backport this one? |
Ok the first has now been safely backported and this one has been labeled. |
) (#3708) Since DCW 1.2.0 is not compatible with GMT 6.1.0 or earlier, we have added a check in the latest GMT to see if a minimum gmt version string exists in DCW (it does from 1.2.0 onwareds) and if so determine if this GMT version passes the test. Co-authored-by: Paul Wessel <[email protected]>
Since DCW 1.2.0 is not compatible with GMT 6.1.0 or earlier, we have added a check in the latest GMT to see if a minimum gmt version string exists in DCW (it does from 1.2.0 onwareds) and if so determine if this GMT version passes the test.
dcw-gmt-1.2.0.tar.gz and zip are available for testing purposes in the usual pwessel/release ftp folder.