Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update a script to GMT modern mode syntax #3673

Closed
wants to merge 1 commit into from

Conversation

wangliang1989
Copy link
Contributor

Description of proposed changes

Fixes #

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@wangliang1989 wangliang1989 changed the title Use the new version of the syntax Update a script to GMT modern mode syntax Jul 18, 2020
Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modern mode scripts cannot use -O -K

@wangliang1989 wangliang1989 changed the title Update a script to GMT modern mode syntax WIP: Update a script to GMT modern mode syntax Jul 19, 2020
@wangliang1989
Copy link
Contributor Author

I need your comment. Thank you.
@PaulWessel

I think this script still have some problems.

  1. The script is in the rst file. I don't think this is a good idea. I have to copy the script to another shell file. After modifying, I need to copy back.
  2. I add the pic by manual. I don't find how to make html on my computer. I guess the original pic file is added by manual too because the original script cannot produce the original pic.
  3. I don't know the style is OK or not. I guess the pic is the first one that is from contributors, whose style is very important because future people will follow it.

I am not a native English speaker, nor do I use English in my daily life

@seisman
Copy link
Member

seisman commented Jul 29, 2020

I think this script still have some problems.

  1. The script is in the rst file. I don't think this is a good idea. I have to copy the script to another shell file. After modifying, I need to copy back.
  2. I add the pic by manual. I don't find how to make html on my computer. I guess the original pic file is added by manual too because the original script cannot produce the original pic.
  3. I don't know the style is OK or not. I guess the pic is the first one that is from contributors, whose style is very important because future people will follow it.

I agree that these are all good points. Currently we haven't decided what's the best way for users to contribute their scripts and plots. To make this PR as small as possible, I think you can focus on the modernization of the script.

#!/usr/bin/env bash
#
gmt set GMT_COMPATIBILITY=5 MAP_FRAME_TYPE=plain
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#!/bin/bash
#!/usr/bin/env bash

@joa-quim
Copy link
Member

This script may not be particular useful and could be improved to not use awk for example, but it was written by Eduardo Suarez who I considered a good friend (though never meat personally) and that passed away suddenly.

I would rather just leave it as is.

@wangliang1989
Copy link
Contributor Author

wangliang1989 commented Jul 29, 2020 via email

@joa-quim
Copy link
Member

Tonight, I will try to update according to the comment of Tian.

Didn't you read what I said?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants