Handle single array item #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to give an array list with a single value we must end with a comma, otherwise it is seen as a fixed increment.
joa-quim
reviewed
Aug 25, 2018
src/gmt_support.c
Outdated
| @@ -15615,7 +15615,7 @@ unsigned int gmt_create_array (struct GMT_CTRL *GMT, char option, struct GMT_ARR | |||
| uint64_t k; | |||
| unsigned int pos = 0; | |||
| char p[GMT_LEN64] = {""}; | |||
| for (k = 0, T->n = 1; k < strlen (T->list); k++) if (T->list[k] == ',') T->n++; /* Count the commas */ | |||
| for (k = 0, T->n = 1; k < strlen (T->list); k++) if (T->list[k] == ',' && T->list[k+1]) T->n++; /* Count the commas */ | |||
There was a problem hiding this comment.
Please break this for() ... if () ... line. Those are awful cases to debug
Breaking up some lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to give an array list via -T with a single value we must end with a comma, otherwise it is seen as a fixed increment instead. For instance, -T5 means use array increment of 5 while -T5, means "create an array with one element which is 5". The -T option is used in many modules, such as sample1d.