Rename module substructure to be unique #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I.e., use struct PSXY_A instead of struct A. That way it is unique across the modules. Closes #3198.
|
There are a few conflicts. |
|
Should be better now, @seisman. |
seisman
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e., use struct PSXY_A instead of struct A. That way it is unique across the modules. Closes #3198.
It is possible a few more needs work since some where already renamed but did not use the full name, e.g. SRF_A instead of SURFACE_A. If anyone wants to hunt down the ones I miss please do.