Revise verbosity default levels and their names and abbreviations #2585

PaulWessel · 2020-01-29T04:26:11Z

Description of proposed changes

See issue #2346 for context. This PR does several things:

Renames three verbosity levels to be more mnemonic: normal is now called error, verbose is called warning, and long_verbose is called information.
Changes the one-character codes for verbosity also to be more mnemonic: n becomes e, v becomes w, and l becomes i (all backwards compatible).
Reinstates warning as the default verbosity level [-V or -Vw] so users can get critical warning messages without knowing they needed -Vv as in the past.
Lets the GMT and PostScriptLight API define the corresponding enums GMT_MSG_INFORMATION instead of GMT_MSG_LONG_VERBOSE, etc., but this is backwards compatible in case a developer uses the old enums.
Updates all references to verbosity in documentation, code and scripts to use the new standards.
Removes leading phrases in GMT_Report messages such as "Syntax error:" or "Warning" since that is standardized by the GMT_Report function via the ERROR, WARNING, INFORMATION, etc. prefixes.
Changes a few warning messages to information messages when not supplying actionable warnings.

Let -Vw (warnings+errors) become the default verbosity, and rename the various choices in a backwards compatible manner.

They are all prefaced by ERROR, WARNING, etc anyway.

Also align revised verbosity in PSL with GMT.

admin/src_replace_word.sh

doc/rst/source/explain_-V_full.rst_

seisman · 2020-01-30T06:01:03Z

I just merged master branch and resolved two conflicts.

seisman

The PR looks good to me, but we may want more comments from @GenericMappingTools/core.

PaulWessel · 2020-01-30T08:10:27Z

Yes agree, perhaps @joa-quim and @remkos can build this branch and see what they think.

remkos · 2020-01-30T14:41:43Z

This is fine with me.
If I understood well, -V does no longer have any effect, i.e. -V and -Vw and no -V at all is all the same.
That is also fine with me.

joa-quim · 2020-01-30T18:35:28Z

Guys, you were too quick on merging.

Sorry, it doesn't make sense to me that -V alone does nothing. If it does nothing it should not exist.
I thought that Let -V mean -Vi means exactly that, but no. This prints nothing

surface lixo.csv -R0/10/0/10 -Gjunk.nc -I0.05 -V

while this does (though it prints too much but that's a different issue)

surface lixo.csv -R0/10/0/10 -Gjunk.nc -I0.05 -Vi

joa-quim · 2020-01-30T19:37:47Z

And things are getting worst. Now this prints a lot of non-needed info, whilst before there was silence

julia> imshow("junk.nc")
gmtread [WARNING]: No range attribute, guessing registration to be pixel
gmtread [WARNING]: netCDF grid junk.nc information has zmin = zmax = NaN. Reset to 0/0.
PSL: Colormap of 10 colors created
PSL: Image depth reduced to 4 bits
psxy [WARNING]: Option -T ignores all input files

PaulWessel · 2020-01-30T19:58:57Z

I will comment and address some of these but busy with getting the proposal submittted now.

PaulWessel · 2020-01-30T21:13:46Z

My intent, as per @seisman's comment, was to let -V stand for -Vi. I thought I fixed that but perhaps not - will look. Yes, we also need to change the level we have assigned to some messages since some labeld WARNING that was never seen are now showed by default. Many of these need to become INFORMATION.

PaulWessel · 2020-01-30T21:19:11Z

BTW, when I run surface -V I get tons of INFORMATION statements. Surely you just too?

joa-quim · 2020-01-30T22:28:16Z

Yes, sure. -V silence. -Vi flooding

seisman · 2020-01-30T22:35:25Z

This is what I have:

$ gmt coast -Rg -JH10c -B0 -Ggray -pdf map

$ gmt coast -Rg -JH10c -B0 -Ggray -pdf map -V
begin [INFORMATION]: Creating a workflow directory /Users/seisman/.gmt/sessions/gmt6.70704
coast [INFORMATION]: Central meridian not given, default to 180
coast [INFORMATION]: Map scale is 3603.99 km per cm or 1:3.60399e+08.
coast [INFORMATION]: -D option: Selected resolution -Dc
coast [INFORMATION]: Selected ice front line as Antarctica coastline
coast [INFORMATION]: GSHHG version 2.3.7
coast [INFORMATION]: Derived from World Vector Shoreline, CIA WDB-II, and Atlas of the Cryosphere
coast [INFORMATION]: Processed by Paul Wessel and Walter H. F. Smith, 1994-2017
end [INFORMATION]: Process GMT figure queue: 1 figures found
end [INFORMATION]: Processing GMT figure #0 [map pdf ]
psconvert [INFORMATION]: Processing /Users/seisman/.gmt/sessions/gmt6.70704/gmt_0.ps-...
psconvert [INFORMATION]: Find HiResBoundingBox ...
psconvert [INFORMATION]: Figure dimensions: Width: 284.961 points [10.0528 cm]  Height: 143.226 points [5.05269 cm]
psconvert [INFORMATION]: [359.241 359.244 644.202 502.47]...
psconvert [INFORMATION]: Convert to PDF...
end [INFORMATION]: Destroying the current workflow directory /Users/seisman/.gmt/sessions/gmt6.70704

$ gmt coast -Rg -JH10c -B0 -Ggray -pdf map -Vi
begin [INFORMATION]: Creating a workflow directory /Users/seisman/.gmt/sessions/gmt6.70704
coast [INFORMATION]: Central meridian not given, default to 180
coast [INFORMATION]: Map scale is 3603.99 km per cm or 1:3.60399e+08.
coast [INFORMATION]: -D option: Selected resolution -Dc
coast [INFORMATION]: Selected ice front line as Antarctica coastline
coast [INFORMATION]: GSHHG version 2.3.7
coast [INFORMATION]: Derived from World Vector Shoreline, CIA WDB-II, and Atlas of the Cryosphere
coast [INFORMATION]: Processed by Paul Wessel and Walter H. F. Smith, 1994-2017
end [INFORMATION]: Process GMT figure queue: 1 figures found
end [INFORMATION]: Processing GMT figure #0 [map pdf ]
psconvert [INFORMATION]: Processing /Users/seisman/.gmt/sessions/gmt6.70704/gmt_0.ps-...
psconvert [INFORMATION]: Find HiResBoundingBox ...
psconvert [INFORMATION]: Figure dimensions: Width: 284.961 points [10.0528 cm]  Height: 143.226 points [5.05269 cm]
psconvert [INFORMATION]: [359.241 359.244 644.202 502.47]...
psconvert [INFORMATION]: Convert to PDF...
end [INFORMATION]: Destroying the current workflow directory /Users/seisman/.gmt/sessions/gmt6.70704

joa-quim · 2020-01-30T22:42:17Z

Yes, I can reproduce that but try this with the attached file

surface lixo.csv -R0/10/0/10 -Gjunk.nc -I0.05 -V

lixo.zip

seisman · 2020-01-30T22:43:50Z

I also got a long message:

gmt surface lixo.csv -R0/10/0/10 -Gjunk.nc -I0.05 -V
surface [INFORMATION]: Cartesian input grid
surface [INFORMATION]: Cartesian input grid
surface [INFORMATION]: Grid domain: W: 0 E: 10 S: 0 N: 10 n_columns: 200 n_rows: 200 [gridline registration]
surface [INFORMATION]: Processing input table data
surface [INFORMATION]: Reading Data Table from file lixo.csv
surface [INFORMATION]: Minimum value of your dataset x,y,z at: 2.53856992722 5.16657018661 0
surface [INFORMATION]: Maximum value of your dataset x,y,z at: 5.27815008163 1.151720047 9
surface [INFORMATION]: Eliminate data points that are not nearest a node.
surface [INFORMATION]: Plane fit z = 5.48785 + (0.0127817 * col) + (-0.0234717 * row)
surface [INFORMATION]: Normalize detrended data constraints by z rms = 2.42055
surface [INFORMATION]: Select default convergence limit of 0.000242055 (100 ppm of L2 scale)
surface [INFORMATION]: Recompute data index for next iteration [stride = 40]
surface [INFORMATION]: ------------------------------------------
surface [INFORMATION]: Memory for data array          : 240 bytes
surface [INFORMATION]: Memory for final grid          :  164.2 kb
surface [INFORMATION]: Memory for Briggs coefficients : 240 bytes
surface [INFORMATION]: Memory for node status         :   41.0 kb
surface [INFORMATION]: ------------------------------------------
surface [INFORMATION]: Total memory use               :  205.7 kb
surface [INFORMATION]: ==========================================
surface [INFORMATION]: Grid	Mode	Iteration	Max Change	Conv Limit	Total Iterations
surface [INFORMATION]: Set finite-difference coefficients [stride = 40]
surface [INFORMATION]: Determine nearest point and set Briggs coefficients [stride = 40]
surface [INFORMATION]:   40	D	    1014	5.91821244257e-06	6.0513852091e-06	      1014
surface [INFORMATION]: Recompute data index for next iteration [stride = 8]
surface [INFORMATION]: Expand grid by factor of 5 when going from stride = 40 to 8
surface [INFORMATION]: Fill in expanded grid by bilinear interpolation [stride = 8]
surface [INFORMATION]:    8	I	     306	2.94900688357e-05	3.02569260455e-05	      1320
surface [INFORMATION]: Determine nearest point and set Briggs coefficients [stride = 8]
surface [INFORMATION]:    8	D	    4000	0.00123970391765	3.02569260455e-05	      5320
surface [INFORMATION]: Recompute data index for next iteration [stride = 4]
surface [INFORMATION]: Expand grid by factor of 2 when going from stride = 8 to 4
surface [INFORMATION]: Fill in expanded grid by bilinear interpolation [stride = 4]
surface [INFORMATION]:    4	I	      22	5.93033165066e-05	6.0513852091e-05	      5342
surface [INFORMATION]: Determine nearest point and set Briggs coefficients [stride = 4]
surface [INFORMATION]:    4	D	    2000	0.00106849393251	6.0513852091e-05	      7342
surface [INFORMATION]: Recompute data index for next iteration [stride = 2]
surface [INFORMATION]: Expand grid by factor of 2 when going from stride = 4 to 2
surface [INFORMATION]: Fill in expanded grid by bilinear interpolation [stride = 2]
surface [INFORMATION]:    2	I	      18	0.000112587427182	0.000121027704182	      7360
surface [INFORMATION]: Determine nearest point and set Briggs coefficients [stride = 2]
surface [INFORMATION]:    2	D	    1000	0.000498276120252	0.000121027704182	      8360
surface [INFORMATION]: Recompute data index for next iteration [stride = 1]
surface [INFORMATION]: Expand grid by factor of 2 when going from stride = 2 to 1
surface [INFORMATION]: Fill in expanded grid by bilinear interpolation [stride = 1]
surface [INFORMATION]:    1	I	      11	0.000218761774326	0.000242055408364	      8371
surface [INFORMATION]: Determine nearest point and set Briggs coefficients [stride = 1]
surface [INFORMATION]:    1	D	     283	0.000241586279657	0.000242055408364	      8654
surface [INFORMATION]: Compute rms misfit and curvature.
surface [INFORMATION]: Fit info: N data points  N nodes	mean error	rms error	curvature
surface [INFORMATION]: 	      10	   40401	-0.000452330934658	0.00633957673331	1121.66847608
surface [INFORMATION]: Writing grid to file junk.nc

joa-quim · 2020-01-30T22:44:04Z

Ah, found something

gmt surface lixo.csv -R0/10/0/10 -Gjunk.nc -I0.05 -V

prints it all

PaulWessel · 2020-01-30T23:02:09Z

Hm, so gmt surface vs surface (bad old-school shorthand, shame on you) ?
We should run the full test with -V and examine the log for unwanted WARNING messages I think.

joa-quim · 2020-01-30T23:11:24Z

Weird, why is that making a difference?
Look like I need to create symlinks to keep old (non-unix conditioned) habits

mklink surface.exe gmt.exe

then it works again.

PaulWessel · 2020-01-30T23:13:33Z

Very odd behavior.

PaulWessel added 8 commits January 28, 2020 15:24

WIP Change order of verbosity

7be0e7d

Let -Vw (warnings+errors) become the default verbosity, and rename the various choices in a backwards compatible manner.

Remove words like syntax error and warnings from GMT_Report strings

7efafb6

They are all prefaced by ERROR, WARNING, etc anyway.

Fix -V references

7783761

Update use of -Vl,n,v

c8b8899

Also align revised verbosity in PSL with GMT.

Fix typos

246252b

State we skip lines

a953d28

Merge branch 'master' into verbose-revision

999b2b5

Typo

d9a4b14

PaulWessel requested review from seisman, joa-quim and remkos January 29, 2020 04:26

PaulWessel added 2 commits January 28, 2020 18:28

Change verbose level of one common report

94b2c52

Make bold

fcc9439

seisman reviewed Jan 29, 2020

View reviewed changes

admin/src_replace_word.sh Outdated Show resolved Hide resolved

doc/rst/source/explain_-V_full.rst_ Outdated Show resolved Hide resolved

PaulWessel and others added 2 commits January 29, 2020 19:49

Let -V mean -Vi

39dcc9f

Merge branch 'master' into verbose-revision

c62f929

seisman approved these changes Jan 30, 2020

View reviewed changes

remkos merged commit 214bbf1 into master Jan 30, 2020

remkos deleted the verbose-revision branch January 30, 2020 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revise verbosity default levels and their names and abbreviations #2585

Revise verbosity default levels and their names and abbreviations #2585

PaulWessel commented Jan 29, 2020 •

edited

Loading

seisman commented Jan 30, 2020

seisman left a comment

PaulWessel commented Jan 30, 2020

remkos commented Jan 30, 2020

joa-quim commented Jan 30, 2020

joa-quim commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

joa-quim commented Jan 30, 2020

seisman commented Jan 30, 2020

joa-quim commented Jan 30, 2020

seisman commented Jan 30, 2020

joa-quim commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

joa-quim commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

Revise verbosity default levels and their names and abbreviations #2585

Revise verbosity default levels and their names and abbreviations #2585

Conversation

PaulWessel commented Jan 29, 2020 • edited Loading

seisman commented Jan 30, 2020

seisman left a comment

Choose a reason for hiding this comment

PaulWessel commented Jan 30, 2020

remkos commented Jan 30, 2020

joa-quim commented Jan 30, 2020

joa-quim commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

joa-quim commented Jan 30, 2020

seisman commented Jan 30, 2020

joa-quim commented Jan 30, 2020

seisman commented Jan 30, 2020

joa-quim commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

joa-quim commented Jan 30, 2020

PaulWessel commented Jan 30, 2020

PaulWessel commented Jan 29, 2020 •

edited

Loading