-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDAL librarify #2583
GDAL librarify #2583
Conversation
Since you are working in a WIP branch, do we really need to approve commits? |
Hm, I didn't request a review. It was some github ghost. |
Ok, but later this week. We said we would release 6.1 soon (February) so we should discuss a checklist with @serisman and see if there are specific things we need to complete first. |
@PaulWessel please have a go with this. I added a -Ns option to
Only the GDAL's |
OK, trying nearneighbor:
What am I doing wrong? |
Ok, do
If you were using
should work too. |
I switched to the GDALlibrify branch, rebuilt everything, and gmt nearneighbor lixo.csv -R0/10/0/10 -Gjunk.nc -I0.05 -Ns ERROR: No module named gmtgdal was found. This could mean one of four cases:
Do you have any other settings in cmake that needs to be applied? |
Ah, forgot about it. I am using the
work. But something screwed meanwhile with |
Wait, don't know why I thought it hadn't work. It does
|
Since your gdal_vector calls GMT_Read_Data I think you need to add support for -i, -h, -q. All you need is to add them to the OPTIONS and the usage part and the rest is automatic. Plus man page. |
It already has. So it misses -q
#define THIS_MODULE_OPTIONS "->RVbhi"
From: Paul Wessel <[email protected]>
Sent: Sunday, February 9, 2020 10:57 PM
To: GenericMappingTools/gmt <[email protected]>
Cc: Joaquim Manuel Freire Luís <[email protected]>; Author <[email protected]>
Subject: Re: [GenericMappingTools/gmt] WIP: GDAL librarify (#2583)
Since your gdal_vector calls GMT_Read_Data I think you need to add support for -i, -h, -q. All you need is to add them to the OPTIONS and the usage part and the rest is automatic. Plus man page.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#2583?email_source=notifications&email_token=AAEDF2ODHR5PVSWFFY5SAFDRCCC4BA5CNFSM4KM4BVOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELG2YJA#issuecomment-583904292>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAEDF2LGVR5I522FOYR662LRCCC4BANCNFSM4KM4BVOA>.
|
OK, the wrapper program name. I named it So far
and at a certain point I think it would be useful to make it write OGR formats out of our table data files (thus avoiding the need of system calls to All of these to say. I have no strong opinion on a Opinions? |
ping @PaulWessel @seisman |
A couple of thoughts: I think for the command line it does not matter. However, I know for the API it is better if a module only returns one type of thing. We are even considering to break some old modules into several to be simpler, and maybe we will do that with modules that returns different things depending on options. Going forward with new modules, I think we should try hard to only make them produce one thing. So I think grdgdal sounds like a much better name for now, and if you end up making a gmtgdal that deals with tables down the line then that just is another well-named module. So I think grdgdal for the current module would be better. |
Right. Agree with that. A gmtgdal might (or not) see the light of day further down the road. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the example in the man page uses -M+W instead of -M+w.
Add structure to call GDAL programs via its C API.
Current implementation already allows calling the
gdal_grid
program using a temporary -A option ofnearneighbor
. An annoying issue is that, so far, simple input data must be passed in ascii via the GDAL's VRT mechanism.As example, put the following into a
lixo.csv
filecreate a
lixo.vrt
file withand run
to get the same as the
nat_nn.sc
test (but, just realized, UD flipped)