pssac: don't draw line if -G is used and -W isn't #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joa-quim
approved these changes
Dec 28, 2018
|
I thinks it should go to 5.4 as well. Plotting the outline without request is a sort of bug. |
|
Merged into master and 5.4 branches. |
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
Simple wrapper method. Doesn't do any IO (delegates to GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Sometimes users may want to fill a seismogram but don't want to plot the line. Old pssac always draw the line no matter -W is used or not. The new pssac will not draw the line if -G is used but -W isn't.
The new pssac is slightly incompatible with the old one. Not sure if we should incorporate it into 5.4 branch.