pssac: first fill then outline #240

seisman · 2018-12-27T15:36:50Z

Description of proposed changes

For a seismogram, pssac should fill the trace before plotting the line, similar to psxy.

Before:

After:

Reminders

Make sure that your code follows our style. Use the other functions/files as a basis.
Add tests for new features or tests that would have caught the bug that you're fixing.
Describe changes to function behavior and arguments in a comment below the function declaration.
If adding new functionality, add a detailed description to the documentation and/or an example.

seisman · 2018-12-27T18:18:04Z

This PR fixes a bug of pssac, and should also be merged into 5.4 branch. I'll cherry-pick this commit into 5.4 branch after approved.

seisman · 2018-12-27T20:53:28Z

I've pushed this commit to 5.4 branch.

seisman changed the title ~~pssac: first fill then outline~~ WIP: pssac: first fill then outline Dec 27, 2018

seisman force-pushed the fix-pssac branch from b87cc61 to 52d2002 Compare December 27, 2018 15:42

pssac: first fill then outline

5bfcd22

seisman force-pushed the fix-pssac branch from 52d2002 to 5bfcd22 Compare December 27, 2018 16:13

seisman requested a review from a team December 27, 2018 16:13

seisman changed the title ~~WIP: pssac: first fill then outline~~ pssac: first fill then outline Dec 27, 2018

joa-quim approved these changes Dec 27, 2018

View reviewed changes

seisman merged commit 521f678 into master Dec 27, 2018

seisman deleted the fix-pssac branch December 27, 2018 20:31

seisman added a commit that referenced this pull request Dec 27, 2018

pssac: first fill then outline (#240)

1768e1f

obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021

Fix wrong link to gmtmex (GenericMappingTools#240)

4617492

Provide feedback