Supply -Baf when colorbar plots a stretched CPT #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tools like grdiimage may produce a stretched CPT taht fits the range of a grid exactly. In those cases we cannot let psscale use the CPT levels as annotation and tick intervals but must override via -Baf. This PR does so by adding a keyword STRETCHED to such CPTs as they are written and then we watch for that word upon reading. CLoses issue #2307.
seisman
reviewed
Dec 21, 2019
|
It works well, but STRETCHED doens't sound a good keyword. Most CPTs are stretched version of master CPTs, right? |
seisman
reviewed
Dec 21, 2019
Co-Authored-By: Dongdong Tian <[email protected]>
Co-Authored-By: Dongdong Tian <[email protected]>
Co-Authored-By: Dongdong Tian <[email protected]>
|
I agree STRETCHED is dumb, will change to something better. But in the end, it is just for internal consumption. |
|
The annotations are still messy when -C+i is used. Try the script below. Perhaps we should add -Baf for all automatically generated CPTs. |
|
Hm, I will debug this later -I must now have understood my implementation of the +idx. If so then yes we would have to do it for all stretched CPTS. |
|
Fixed, will commit after tests complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools like grdimage may produce a stretched CPT that fits the z-range of a grid exactly. In those cases we cannot let psscale use the CPT levels as annotation and tick intervals but must override via -Baf. This PR does so by adding a comment keyword STRETCHED to such CPTs as they are written and then we watch for that word upon reading. Closes issue #2307.