Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed coast -Td, -Tm via explain_-T_rose #2243

Closed

Conversation

tparker37
Copy link

@tparker37 tparker37 commented Dec 8, 2019

Fixed [coast -Td, -Tm] from explain_-T_rose: Don't repeat the option, just say
Completed during AGU2019 workshop

Fixes #2227

Reminders

  • Correct base branch selected? master for new features, 6.0 for bug fixes
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

Fixed [coast -Td, -Tm] from explain_-T_rose: Don't repeat the option, just say 
Completed during AGU2019 workshop

Fixes #
@welcome
Copy link

welcome bot commented Dec 8, 2019

💖 Thanks for opening this pull request! 💖

Please make sure you read our Contributing Guide and abide by our Code of Conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the comments below for your functions describing the it, all arguments, and return types before writing the code. This will help you think about your code design and results in better code.
  • We are grateful that you put in the effort to do this! 🎉

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but please change the first Draws to Draw, if you can.

@@ -1,5 +1,5 @@
**-Td**\ [**g**\ \|\ **j**\ \|\ **J**\ \|\ **n**\ \|\ **x**]\ *refpoint*\ **+w**\ *width*\ [**+f**\ [*level*]]\ [**+j**\ *justify*]\ [**+l**\ *w,e,s,n*][**+o**\ *dx*\ [/*dy*]]
**-Td** draws a map directional rose on the map at the location defined by
Draws a map directional rose on the map at the location defined by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Draws a map directional rose on the map at the location defined by
Draw a map directional rose on the map at the location defined by

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have permission to commit those suggestions, apparently.

Copy link
Member

@seisman seisman Dec 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too. We have to wait for @tparker37 to respond, or we can open a separate PR.

@seisman seisman mentioned this pull request Dec 18, 2019
@seisman seisman closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coast -Td, -Tm: Don't repeat the option, just say Draw…
3 participants