Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new C program for testing #21

Merged
merged 1 commit into from
Aug 17, 2018
Merged

add new C program for testing #21

merged 1 commit into from
Aug 17, 2018

Conversation

PaulWessel
Copy link
Member

testgmtshell.c basically can run plain shell scripts but maintains a single GMT SESSION.

It starts a single GMT session and passes all lines starting with gmt via GMT_Call_Module while all other non-comment lines are executed via a system calls. Thus, no variable assignments etc. It is used to fine any issues related to a long-lived GMT session (such as in MATLAB, Octave).

testgntshell.c basically can run plain shell scripts but maintains a single GMT SESSION.
@PaulWessel PaulWessel requested a review from a team August 17, 2018 20:42
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@PaulWessel PaulWessel closed this Aug 17, 2018
@PaulWessel PaulWessel deleted the newCtest branch August 17, 2018 21:54
@leouieda
Copy link
Member

@PaulWessel the PR was closed instead of merged. Is that what you intended?

@PaulWessel
Copy link
Member Author

PaulWessel commented Aug 17, 2018 via email

@joa-quim
Copy link
Member

I guess you have to commit it again since the branch was deleted without merging.

@leouieda leouieda restored the newCtest branch August 17, 2018 22:09
@leouieda
Copy link
Member

No need

@leouieda
Copy link
Member

I'll restore the branch and reopen the PR.

@leouieda leouieda reopened this Aug 17, 2018
@leouieda
Copy link
Member

Now we wait for Travis and merge it. This is common enough that Github won't delete your branch for real right away.

@leouieda leouieda merged commit 4eb6cb0 into master Aug 17, 2018
@leouieda leouieda deleted the newCtest branch August 17, 2018 22:17
@leouieda
Copy link
Member

Done 🚀

@PaulWessel
Copy link
Member Author

Thanks!

@akshmakov
Copy link

Git in general will never delete commits ever, ( well unless you really try) . Even when you rebase or force push a branch the existing commits are still around.

Deleting a branch only deletes a reference to an existing commit. It is always recoverable by simply checking out the commit by hash, recreating the branch and pushing again .

obaney referenced this pull request in obaney/gmt Aug 18, 2021
…ls#103)

Fixes #21

Implemented in build_arg_string instead of kwargs_to_strings because
we can't have multiple entries in a dictionary with the same key.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants