Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading beyond band 9 of when only a single band is selected. #192

Merged
merged 2 commits into from
Nov 27, 2018

Conversation

joa-quim
Copy link
Member

Addresses an issue raised in the forum where reading beyond band 9 was in fact reading band 0.
However, debugging this case revealed that band selections beyond 3'rth band for images that have more than 3 bands will also be wrong.

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but dont understand what the comma,dash section is meant to actually do.

@PaulWessel PaulWessel merged commit a292bf0 into master Nov 27, 2018
@joa-quim
Copy link
Member Author

What it does it to let you select the bands of an RGB image in any order and recombine them. But the logic breaks beyond 3 bands.

@seisman seisman deleted the bands branch December 20, 2018 21:29
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
`ci` directory was removed in GenericMappingTools#188. Remove `ci` in `setup.py` 
and `.codeclimate.yml`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants