Parsing of +n<length>[<unit>] should not override the default unit for data input #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t for data input The bug was that +n1c would change the deafult dimension to cm for data input even though --PROJ_LENGTH_UNIT=inch was given. Now, the length is parsed and converted to inchs but no unit is recorded. Furthermore, arrowline.sh had some bugs (used - instead of -- to set a default value) and vectors.sh were affected by the +n bug so I just changed its unit so the PS is the same. The arrowline.ps file needed to be updated as well.
Missed a word and repeted -E twice.
joa-quim
approved these changes
Nov 11, 2018
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
The shared library was being loaded in `__init__`, which is not a good design pattern. Instead, now it's loaded the first time it gets used by the new method `get_libgmt_func` that gets the ctypes function and sets the return and argument types. This removes some redundancy from the other methods (setting ctypes type conversions) and also removes the usage of a private variable `_libgmt` from other methods. Now, only methods that set a private variable need to know of it's existence. The same applies to `_session_id` which is entirely encapsulated by `current_session`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that +n1c would change the default dimension to cm for data input even though --PROJ_LENGTH_UNIT=inch was given. Now, the length is parsed and converted to inches but no unit is recorded. Furthermore, arrowline.sh had some bugs (used - instead of -- to set a default value) and vectors.sh were affected by the +n bug so I just changed its unit so the PS is the same. The arrowline.ps file needed to be updated as well.