Improve representation of pi fractions #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle anything up to 1/20th of pi, ensure this labeling is only applied on the axes that requests it.
It incorreclty used symbol font for the numbers.
joa-quim
approved these changes
Nov 9, 2018
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
…#173) Includes the version information and paths to libgmt and data. Will be used later on to test the GMT version number. Fixes GenericMappingTools#169 Turns out it segfaults for API_DATADIR for some reason. Might be a GMT problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original algorithm only dealt with certain fractions and only if <= 2 pi. Now we handle anything value with a granularity up to multiples of 1/20th of pi, and we also ensure this labeling is only applied on the axes that requested increments in pi.
*Fixes #172 , but note you probably want to use -Bpxa1pi2 to avoid pi on the y-axis as well.