Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Cleanup Julia and matlab scripts #1716

Merged
merged 1 commit into from
Oct 4, 2019
Merged

docs: Cleanup Julia and matlab scripts #1716

merged 1 commit into from
Oct 4, 2019

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 2, 2019

These Julia and Matlab scripts are not used in the GMT documentation.
Even if these scripts are useful, they should be put in their own
repositories.

@PaulWessel
Copy link
Member

Hi @joa-quim, could you copy/paste/add these to the suitable repos?

@joa-quim
Copy link
Member

joa-quim commented Oct 2, 2019

The point is that those tests (and there are couple more) are more or less useless outside the GMT tests tree. Not these in particular that require no input, but others. And I don't see the logic of the purge. We have bash and bat tests, having them in other languages is just an extension. Aside, regarding the 2 julia tests, they are very outdated and can be removed. The other 2, well yes, there not particularly useful.

@seisman
Copy link
Member Author

seisman commented Oct 2, 2019

The reason of the purge is that these scripts are never tested or maintained.

@joa-quim
Copy link
Member

joa-quim commented Oct 3, 2019

The fact that there is no automatic service running those scripts doesn't mean they are never used (I wrote them for a purpose). Again, regarding these 4 scripts the julia ones can be removed but for the Matlab I have hopes that we will be able to run CI Matlab scripts. Talked yesterday with a ML engineer and she told me they are working on a solution for that.

@PaulWessel
Copy link
Member

But isn't the point that they cannot run without also installing the gmt mex and Julia stuff? Installing just GMT is not enough, hence they below in the gmt mex and gmt julia repos since both of those depend on GMT. They dont have to live in the gmt repo to be run from some specific directory.

@joa-quim
Copy link
Member

joa-quim commented Oct 3, 2019

I've been telling that there are more of those .m scripts that sit next to their bash cousins, but I'm OK to delete them all.

Capture

@seisman
Copy link
Member Author

seisman commented Oct 3, 2019

I didn't notice that there are so many matlab scripts hidden in the test directory. They definitely should be moved to the gmtmex repository.

These Julia and Matlab scripts are not used in the GMT documentation.
Even if these scripts are useful, they should be put in their own
repositories.
@seisman seisman merged commit 21c5c89 into 6.0 Oct 4, 2019
@seisman seisman deleted the cleanup-jl-ml branch October 4, 2019 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants