The SORT operator in gmtmath only worked on one column #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole point was to sort the entire table based on the sorting result of the specified column. This required a special check in gmtmath since it normally operates on one column at the time.
joa-quim
approved these changes
Oct 29, 2018
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
There was some redundancy in the existing methods so unify them under a single method. It decomposes the constant values (with or without modifiers, e.g. `"GMT_IS_DATASET|GMT_VIA_MATRIX"`), validates them, and converts them to their integer representation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole point of the SORT operator was to let the user sort the entire table based on the sorting result of the specified column. To implement this required me to add a special check in gmtmath since it normally operates on one column at the time.