Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPT to plot magnetic anomaly maps. #1488

Merged
merged 10 commits into from
Sep 3, 2019
Merged

CPT to plot magnetic anomaly maps. #1488

merged 10 commits into from
Sep 3, 2019

Conversation

joa-quim
Copy link
Member

@joa-quim joa-quim commented Sep 3, 2019

It's the one used in IPGP for decades

Copy link
Member

@PaulWessel PaulWessel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots more work than that to add an extra CPT. There is gmt_cpt_masters.h and GMT_App_M_1?.sh, etc. I dont think we should ship undocumented CPTs hidden in share. You can do that in the cache.

@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

The GMT_App_M_1? are complicated and the three pages are full. What you mean do it in the cache

@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

And speaking of new CPT's. Shouldn't we add the new rainbow from Google that I mentioned you?

@PaulWessel
Copy link
Member

There is room for adding a pair of CPTs so if you get the google one too. However, that one has no hinge and should be normalized to 0-1 in z (see others). I think the mag has a hinge (zero mag) but no zero entry in the CPT. It would probably be best to split that -50 to 50 up in to -50 to 0 and 0 to 50 for that reason, and add the HINGE flag.
I can help with App M.

@PaulWessel
Copy link
Member

OK, what do we call the google cut? google? spectrum? Once you add it I can go to work on App M.

@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

Well, they called it turbo. It's a stupid name but that's how it's going to be known.
Still trying to see how to reformat it.

@PaulWessel
Copy link
Member

OK, turbo is fine since it is not already used.

@PaulWessel
Copy link
Member

Need entry in gmt_cpt_masters.h for turbo.

@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

Done. I think this turbo is a candidate to a new default CPT (if that is still on the table)

@joa-quim joa-quim changed the title CPT to plot magnetic anomaly maps. It's the one used in IPGP for decades CPT to plot magnetic anomaly maps. Sep 3, 2019
@PaulWessel
Copy link
Member

So some difficulty with App. We have 71 CPTs in gmt_cpt_masters.h, but one we skip (srtm which is same as dem4 on land only). So 70 minus the 24 from Fabio = 46. To split into two pages with two columns that number needs to be divisible by 4. So we actually need 48. Are we able to come up with 2 more CPTs.

@PaulWessel
Copy link
Member

How about cequal [http:https://soliton.vm.bytemark.co.uk/pub/cpt-city/imagej/tn/cequal.png.index.html] and columbia [http:https://soliton.vm.bytemark.co.uk/pub/cpt-city/wkp/shadowxfox/index.html]?

@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

And what about dropping 2? We already have more than enough generic ones.

@PaulWessel
Copy link
Member

Would give backwards compatibility headaches. Better to add two. OK, could remove two from the table but leave in share - that is backwards compatible since the gmt_cpt_masters.h is only used for listing (and by App M). What to remove?

@PaulWessel
Copy link
Member

Maybe seafloor and wysiwyg?

@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

wysiwyg is a good candidate. And the acton? We only break some compat if remove old ones. New ones were technically never really released.

@PaulWessel
Copy link
Member

acton is part of Fabio so does not help with the 24 problem.

@PaulWessel
Copy link
Member

I think seafloor is pretty useless and there is ibcao, bathy, abyss already.

@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

Yes, we have several seaflors. Panoply seems pretty useless too.

@PaulWessel
Copy link
Member

I'll remove seafloor and wysiwyg. Remko loves panoply...

Undocument seafloor and wysiwyg form the App M listings.  Still in share so backwards compatible.
@seisman
Copy link
Member

seisman commented Sep 3, 2019

Why do we have to remove two CPTs? Can we list all 70 cpts in one long paper? Or can we have 24, 22, and 24 cpts in three pages?

@PaulWessel
Copy link
Member

OK, done and updated M 1b PS. Now for discussion of turbo vs rainbow. I would think we agree that turbo is a much improved rainbow without being washed out as in Fabio, no? Maybe @seisman might agree as well?

@PaulWessel
Copy link
Member

Words of wisdom from @seisman. We don't have to make 3 separate M plots. We could keep the Fabio stuff separate and then do everything else as a longer page. We are no longer dealing with page plotting. I will see what I can do - the App M script is messy...

@seisman
Copy link
Member

seisman commented Sep 3, 2019

I once tried to rewrite the three App M scripts with subplot. It's more readable but much slower.

Got them all to fit in APp M.
@PaulWessel
Copy link
Member

I got things to fit as @seisman suggested with 24, 22, 24 on three pages.
Opinions on making turbo the new rainbow default CPT in GMT 6?

@PaulWessel
Copy link
Member

Changing to turbo will probably affect some of our PS origs.

@seisman
Copy link
Member

seisman commented Sep 3, 2019

I have no objection.

Makes it easier to change the default palette in the future.
@joa-quim
Copy link
Member Author

joa-quim commented Sep 3, 2019

I'm very favorable. It's not only the perceptual thing but also that it drops the violet, which always felt wrong on topography maps.

@PaulWessel
Copy link
Member

Running all tests but having trouble:

psxy [ERROR]: Unable to down file http:https://oceania.generic-mapping-tools.org/gmt_md5_server.txt

Not sure why this is happening but I have seen it before. So lots of failures obviously if we cannot get the cache files.

@PaulWessel
Copy link
Member

We are finding out that possibly due to a UH firewall change, nodes INSIDE the UH network cannot access oceania but nodes on the outside can. The SOEST IT staff says it has nothing to do with the SOEST firewall, but there seems to be some infinite loop being set up when we try within UH.

@seisman
Copy link
Member

seisman commented Sep 3, 2019

I'm back now. Should I push the updated PS files to this branch?

@PaulWessel
Copy link
Member

Yes please, I am unable to access the cache since I am inside the UH network...

@seisman
Copy link
Member

seisman commented Sep 3, 2019

Updated 10 PS files.

@PaulWessel
Copy link
Member

So if tests pass for you then I guess we can merge this PR?

Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge.

@PaulWessel PaulWessel merged commit 41a6dbf into 6.0 Sep 3, 2019
@PaulWessel PaulWessel deleted the magcpt branch September 3, 2019 21:06
@PaulWessel
Copy link
Member

Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants