Handle unit for vector shrinking in grdvector #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vector attribute processing keeps track of normalizing length and unit and applies the conversion later since some programs (like psxy) may read such instructions from the command line. In grdcontour, however, there is no such reading and we must convert any lenth to inches before plotting.
joa-quim
approved these changes
Oct 21, 2018
|
I'm afraid we have more of these. From also shows a similar bug. |
obaney
pushed a commit
to obaney/gmt
that referenced
this pull request
Aug 18, 2021
…ls#136) Was using a KML preview loaded on WorldWind Web for the globe preview. The problem was that the file needed to be in the same folder as the notebook and couldn't be deleted after the preview was used. Got around that by using a SurfaceImage layer instead of a KML layer. The SurfaceImage takes a PNG image and region and displays it on the globe. The PNG can be inserted as a base64 encoded string using the Javascript Image object. This eliminates the need to keep the preview files around. I capture the plot region by saving a KML preview and extracting the bounding box from the KML file. This is better than intercepting the 'region' argument in the _preprocess method because it works for ISO country codes as well. With the region, I can automatically set the view point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vector attribute processing keeps track of normalizing length and unit and applies the conversion later since some programs (like psxy) may read such instructions from the command line. In grdcontour, however, there is no such reading and we must convert any length to inches before plotting.
The initial problem was detected by @joa-quim when comparing
-Q0.1i+e+n0.63c
-Q0.1i+e+n0.25c
which should be identical. This PR makes them so.