Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less strict on the dx = dy checking #127

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Less strict on the dx = dy checking #127

merged 1 commit into from
Oct 18, 2018

Conversation

PaulWessel
Copy link
Member

The code was a bit harsh checking if xinc == yinc so even 1e-13 differences would trigger an exit.

This addresses http:https://gmt.soest.hawaii.edu/boards/1/topics/7669?r=7670#message-7670 partly.

The  code was a bit harsh checking if xinc == yinc so even 1e-13 differences would trigger an exit.
@PaulWessel PaulWessel requested a review from a team October 18, 2018 04:33
Copy link
Contributor

@remkos remkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me.

@remkos remkos merged commit f87252e into master Oct 18, 2018
@remkos remkos deleted the grd2kml_fix branch October 18, 2018 06:44
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
…ls#127)

Create a new package called gmt.helpers that contains all of the helper
functions, decorators, classes, and context managers. Helps organize the
imports and establish an API for the helpers. Include a listing in the
API docs for this package. This way, the main modules will contain only
the actual GMT wrapper code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants