Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make work the option that compute valleys. #117

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Make work the option that compute valleys. #117

merged 2 commits into from
Oct 11, 2018

Conversation

joa-quim
Copy link
Member

@joa-quim joa-quim commented Oct 9, 2018

Compute valleys too

@PaulWessel PaulWessel merged commit a7d5353 into master Oct 11, 2018
@PaulWessel PaulWessel deleted the grdppa2 branch October 11, 2018 00:44
PaulWessel added a commit that referenced this pull request Jul 14, 2019
See #1171.  This PR fixes this issue.  However, future improvements are needed; I have added taht to #117.
PaulWessel added a commit that referenced this pull request Jul 14, 2019
See #1171.  This PR fixes this issue.  However, future improvements are needed; I have added taht to #117.
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
Work on GenericMappingTools#88 

The class creates a named temporary file with default 'gmt-python' prefix
and closes the file so that GMT can write to it. It cleans the file upon exit
and has methods to read the text or load data using numpy.
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
Fixes GenericMappingTools#88 and complements GenericMappingTools#117 

Use the new `GMTTempFile` class instead of `NamedTemporaryFile`
in tests that require temp files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants