Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to defeat minGW insanity on path replacements #1069

Closed
wants to merge 3 commits into from

Conversation

PaulWessel
Copy link
Member

With minGW replacing /a with A: we must undo this craziness before trying to open files. See #1035 for context.

With minGW replacing /a with A: we must undo this craziness before trying to open files.  See #1035 for context.
@PaulWessel PaulWessel requested a review from seisman July 1, 2019 02:55
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error on Windows:

unresolved external symbol support_char_count referenced in function mingw_undo_path_substi
tution

Needs to be exported for WIndows to find stuff.
@PaulWessel PaulWessel requested a review from seisman July 1, 2019 04:53
Replace leading X:X: with X:
@seisman
Copy link
Member

seisman commented Jul 2, 2019

Closed as it won't be merged.

@seisman seisman closed this Jul 2, 2019
@seisman seisman deleted the mingwinsanity branch July 2, 2019 05:15
obaney pushed a commit to obaney/gmt that referenced this pull request Aug 18, 2021
GenericMappingTools#1069)

Test pygmt/tests/test_sphinx_gallery.py needs sphinx-gallery to work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants