-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify potential supplement modules to use z positive up for relief #6818
Comments
I think we should go 1. My main reason to advocate this are the wrappers. If working from one of those environments it will be common to have the bathymetry/topography grid already in memory. Then to use different modules that use different z sign convention one would be obliged to, eventually back and forth, multiply the grid by -1 and not only tell the GMT reading function to do it when reading the data. Then all of these modules should have that initial warning about the vertical system used and point users to the +s modifiers to change data sign. |
What is your thought regarding action 2? Since taking action 1 changes the default direction for some modules, having -A to restore what it was seems a bit silly since the meaning of -A now has changed too. |
Remove them but let them active. Thanks to Ubuntu we'll have many old versions around for many years and users may consult manuals of older versions and in fact use newer ones or pass scripts to others that are more up to date. Edit: ohs, sorry I replied when you had only up to the question marque. |
OK, since this supplement is just you and me I think there is a plan for action. I will go through each module slowly (especially as I am using many of them in research) and try to avoid giant PRs covering everything. |
I should say that as I am starting to look at mine, e.g. gmtflexure, it actually reports flexure as z positive up, so perhaps the damage is less wide-spread than I first reported... |
See #6818 for background. This PR improves the discussion of water depth (related to density contrasts) and reference depth (-Z, now specified as a distance). Also added an include _rst file that explains the geometry. This file will be included in other modules as I revise them.
* Clarify z is positive up and eliminate -A in gravprisms See #6818 for background. This PR improves the discussion of water depth (related to density contrasts) and reference depth (-Z, now specified as a distance). Also added an include _rst file that explains the geometry. This file will be included in other modules as I revise them. * finalize removal of -A and update test * Update gravprisms.rst * Update docs also * Update gravprisms.rst
Description of the desired feature
Except for grdredpol, all potential modules either accept a topographic grid or profile, and/or in some cases create a topographic grid or profile. Topographic input to modules computing flexure (gmtflexure, grdflexure, gravfft -T) all agree that the load surface has z positive up. However, the signs of other input and output data vary across the supplement which leads to frustration and confusion (I speak as a user now):
Because this supplement is only used by geophysicists doing grav, mag, flexure, any changes we do have limited impact. Here are suggestions for changes to make this supplement self-consistent.
I think it is a nice goal to have the entire supplement agree on where positive z goes, and because of the limited impact I am willing to declare bugs to fix this mess. However, happy to hear comments from @GenericMappingTools/core.
The text was updated successfully, but these errors were encountered: