Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'is_in_kwargs' with buildin function 'in' #1287

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

ZMAlt
Copy link
Contributor

@ZMAlt ZMAlt commented Oct 12, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

Merging #1287 (42dc1eb) into master (04cefae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1287   +/-   ##
=======================================
  Coverage   91.54%   91.55%           
=======================================
  Files         130      130           
  Lines       15751    15736   -15     
=======================================
- Hits        14420    14407   -13     
+ Misses       1331     1329    -2     
Files Coverage Δ
src/common_options.jl 95.59% <ø> (-0.05%) ⬇️
src/imshow.jl 88.88% <100.00%> (ø)
src/plot.jl 96.71% <100.00%> (ø)

... and 3 files with indirect coverage changes

@joa-quim joa-quim merged commit d608e1b into GenericMappingTools:master Oct 13, 2023
5 of 7 checks passed
@ZMAlt ZMAlt deleted the replace branch October 13, 2023 10:45
joa-quim added a commit that referenced this pull request Nov 23, 2023
Revert #1287 that removed is_in_kwargs and broke several things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants