-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leakage in contourf filled contours? #470
Comments
Hmm, don't know what is going on but it's on the pure GMT side. Saving the
shows the same effect |
Just letting you know I am looking at this. Not visible with -Qidpi. |
grdview has lots of comments regarding past problems (near line 1660), which is very helpful. We are making sure small (the noise we add to prevent a contour from going exactly through a node) is not smaller then floating point EPS, but it can be larger. Here it was 0.000364651 based on
I wonder why it cannot just (always) be just slightly larger than EPS (e.g., 1.0e-7). When I set small to that value the problem went away. So I understand the problem and will work on a solution. |
See GenericMappingTools/GMT.jl#470 for context. The issue was that small was too large.
* Use FLT_EPSILON to move contour from corner See GenericMappingTools/GMT.jl#470 for context. The issue was that small was too large. * Check node use * Update grdview.c
This is now solved in GMT. |
Dear Joaquim and Paul, just a word of recognition for your follow up and for the very fast code fix. Thank you. |
There seems to be some leakage in GMT's contourf filled contours, as per code below and attached picture with result.
I have GMT "6.2.0_6f6d002-dirty_2020.10.19" installed in Windows 10 and I am running Julia 1.5.2 using VS Code.
The text was updated successfully, but these errors were encountered: