-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bit/Bool syntax in statplots.jl : "|" is not a unary operator #1223
Comments
Sorry, not a good time for changes (will leave in vacations). But other things (don't remember which by memory) will not work in 1.6 as well. |
joa-quim
added a commit
that referenced
this issue
Nov 6, 2023
Sorry, forgot this but I'm afraid there is nothing we can do here. GMT.jl does not build with Julia1.6 anymore since the introduction of the GMT_jll artifact because a chain of dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a bit of syntax that uses the
.
operator combined with the boolean||
operator here:https://github.com/GenericMappingTools/GMT.jl/blob/master/src/statplots.jl#L385
This works on newer versions of Julia, but not older versions. For example, that kind of syntax produces an error on the current LTS release of Julia, 1.6.7.
I think this code:
ind = ind_l .|| ind_h
Could be replaced with this code to in order to work in more places:
ind = collect(ind_l .| ind_h)
For a quick example, try running this test script with different Julia versions:
The text was updated successfully, but these errors were encountered: