Skip to content

Commit

Permalink
feat(lsp): support linking to symbols in JSDoc on hover (denoland#13631)
Browse files Browse the repository at this point in the history
  • Loading branch information
kitsonk authored Feb 9, 2022
1 parent 773f882 commit 2f2c778
Show file tree
Hide file tree
Showing 3 changed files with 250 additions and 42 deletions.
6 changes: 3 additions & 3 deletions cli/lsp/language_server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ impl Inner {
error!("Unable to get quick info: {}", err);
LspError::internal_error()
})?;
maybe_quick_info.map(|qi| qi.to_hover(line_index))
maybe_quick_info.map(|qi| qi.to_hover(line_index, self))
};
self.performance.measure(mark);
Ok(hover)
Expand Down Expand Up @@ -1724,7 +1724,7 @@ impl Inner {
},
)?;
if let Some(completion_info) = maybe_completion_info {
completion_info.as_completion_item(&params)
completion_info.as_completion_item(&params, self)
} else {
error!(
"Received an undefined response from tsc for completion details."
Expand Down Expand Up @@ -2265,7 +2265,7 @@ impl Inner {
})?;

if let Some(signature_help_items) = maybe_signature_help_items {
let signature_help = signature_help_items.into_signature_help();
let signature_help = signature_help_items.into_signature_help(self);
self.performance.measure(mark);
Ok(Some(signature_help))
} else {
Expand Down
Loading

0 comments on commit 2f2c778

Please sign in to comment.