This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Switch from ansi-wl-pprint to the prettyprinter package. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kquick
reviewed
Nov 20, 2020
brianhuffman
pushed a commit
to GaloisInc/saw-core-coq
that referenced
this pull request
Nov 22, 2020
This was referenced Nov 22, 2020
added 4 commits
November 24, 2020 05:00
type SawDoc = Doc SawStyle This lets later packages import `Verifier.SAW.Term.Pretty` without conflicting with the `Prettyprinter` module.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 24, 2020
Submodules updated to use prettyprinter: - saw-core: GaloisInc/saw-core#106 TODO: GaloisInc/saw-core-coq#28. WARNING: Do not merge this commit until the corresponding submodule PRs are merged and the submodule references in this commit can be updated to point to the merge commits.
4e36f64
to
a1c42e0
Compare
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 24, 2020
Submodules updated to use prettyprinter: - saw-core: GaloisInc/saw-core#106 TODO: GaloisInc/saw-core-coq#28. WARNING: Do not merge this commit until the corresponding submodule PRs are merged and the submodule references in this commit can be updated to point to the merge commits.
|
Tests from this repo are passing, and we have a working draft PR that shows that saw-script can accommodate these changes (GaloisInc/saw-script#931), so I think this PR is ready to merge into master. |
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 24, 2020
Submodules updated to use prettyprinter: - saw-core: GaloisInc/saw-core#106 TODO: GaloisInc/saw-core-coq#28. WARNING: Do not merge this commit until the corresponding submodule PRs are merged and the submodule references in this commit can be updated to point to the merge commits.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 24, 2020
Some code within saw-script is also now using `prettyprinter` instead of `ansi-wl-pprint`.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 30, 2020
Some code within saw-script is also now using `prettyprinter` instead of `ansi-wl-pprint`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105.