This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
Implement intToNat
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7
| Nothing -> | ||
| let z = svInteger KUnbounded 0 | ||
| i' = svIte (svLessThan i z) z i | ||
| in pure (VToNat (VInt i')) |
There was a problem hiding this comment.
Up to now the VToNat has been used only to represent the bvToNat function, which converts a bitvector to a symbolic natural; so the argument to VToNat would always have a bitvector type. This change would apply VToNat to a VInt value, which none of the existing implementations of saw-core primitives can handle.
There was a problem hiding this comment.
That's true. Unfortunately, not all of the primitives are prepared to handle bitvectors coerced in this way either.
CF https://github.com/GaloisInc/saw-core/issues/58
We could panic here on non-concrete integers, but that doesn't really seem better.
brianhuffman
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7