Dbg def use #886
Merged
Dbg def use #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now compute sucessor and predecessor blocks and perform def/use analysis for each basic block. This def/use analysis specifically omits values embedded in metadata nodes in order to help us discover which debugging intrinsics need to be specially handled.
CFG is valid. This ensures that all non-metadata uses of virtual registers are proper, i.e., that their def sites dominate all use sites. In addition, track the set of live virtual registers during translation. This allows us to check which metadata values are properly defined as we translate them, in particular, for debugging intrinsics. Since these intrinsics don't necessarily follow the usual rules regarding use/def, it can sometimes happen that metadata values are not properly defined. In such cases we simply omit the ill-formed debugging intrinsic information. Fixes #798
RyanGlScott
reviewed
Oct 13, 2021
Add comments and other minor tweaks.
RyanGlScott
reviewed
Oct 14, 2021
There was a problem hiding this comment.
This is exciting! I have not read every line thoroughly, but if the example from #778 works, I'm happy.
crucible-llvm/src/Lang/Crucible/LLVM/Translation/Instruction.hs
Outdated
Show resolved
Hide resolved
| @@ -219,7 +219,7 @@ translateLLVMModule :: | |||
| IO SomeModuleContext' | |||
| translateLLVMModule llOpts halloc memVar moduleFilePath llvmMod = | |||
| do | |||
| Some trans <- | |||
| (Some trans, _warns) <- -- TODO? should we do something with these warnings? | |||
There was a problem hiding this comment.
What do you think about this, @langston-barrett? Should uc-crux-llvm emit warnings discovered during translation?
typos and such Co-authored-by: Ryan Scott <[email protected]>
…form. Refactor slightly how function calls are translated. All code paths would enter their monadic continuation, so pull it back into `generateInstr`.
RyanGlScott
approved these changes
Oct 14, 2021
|
I've verified locally that the program from #778 now works as expected. When |
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Oct 25, 2021
This adds a new translation-warnings output to function `translateModule`. Currently the translation warnings are ignored.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 12, 2021
This adds a new translation-warnings output to function `translateModule`. Currently the translation warnings are ignored.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Nov 12, 2021
This adds a new translation-warnings output to function `translateModule`. Currently the translation warnings are ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.