crucible-jvm: Add permission bit for writability to each static field. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The permission bit is asserted to be true on every putstatic instruction. This feature will allow SAW to use method specs that do not explicitly specify a final value for each static field; by making those fields read-only, we can be sure that the values did not change, without having to explicitly check that the final value is equal to the initial value.
RyanGlScott
reviewed
May 10, 2021
| J.FieldId -> | ||
| W4.Pred sym -> | ||
| IO (C.SymGlobalState sym) | ||
| doStaticFieldWritable sym jc globals fid val = |
There was a problem hiding this comment.
The implementations of this function, doStaticFieldStore, and doStaticFieldLoad are nearly identical except for the Just case. Can the common bits be factored out?
added 5 commits
May 10, 2021 10:27
Also use a variation on the variable name for the writability bit.
brianhuffman
force-pushed
the
jvm-static-field-writable
branch
from
3fc7017
to
b2f49a5
Compare
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
May 12, 2021
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
May 12, 2021
robdockins
approved these changes
May 12, 2021
|
We've discussed the crux-llvm test failures on macos separately; those are due to an LLVM version issue on the build machines, and are unrelated to this PR. |
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
May 14, 2021
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permission bit is asserted to be true on every putstatic instruction.
This feature will allow SAW to use method specs that do not explicitly
specify a final value for each static field; by making those fields
read-only, we can be sure that the values did not change, without having
to explicitly check that the final value is equal to the initial value.
This will be used to address GaloisInc/saw-script#1066.