Changes to crucible-jvm field operations #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 3, 2020 15:30
The `FieldId` type already contains a `ClassName`; we don't need to have a separate `ClassName` as part of the map key.
Previously the field name was specified with only a string, which was used directly as a key to the internal map. This required users to know the correct string format, which must agree with the one specified in `fieldIdText`. Now those internal details are no longer user-visible.
These are variants of the `putstatic` and `getstatic` instructions that can be run in the `IO` monad; they are intended to be used to set up memory states and implement overrides in saw-script, for example.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Dec 16, 2020
This patch includes PR GaloisInc/crucible#589. Functions `doFieldStore` and `doFieldLoad` now take a `FieldId` instead of just a `String`.
brianhuffman
pushed a commit
to GaloisInc/saw-script
that referenced
this pull request
Jan 7, 2021
This patch includes PR GaloisInc/crucible#589. Functions `doFieldStore` and `doFieldLoad` now take a `FieldId` instead of just a `String`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few changes to the APIs for loading and storing of instance fields and static fields:
staticFieldsmap ofJVMContext.doFieldLoadanddoFieldStorenow take aFieldIdinstead of a stringdoStaticFieldStoreanddoStaticFieldLoadgetfieldandgetstatic