Mem alloc array check #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a predicate indicating when the returned array is actually an appropriate backing array for the given pointer. This removes the syntactic check that the predicate reduces concretely to True, and also handles the case where a backing array can only be found on some branches of a merge. However, the call sites in this module (`writeMemWithAllocationCheck`, and `readMem`) still rely on a syntactic check against the predicate; otherwise, they fall back on other behavior. The overall behavior of those operations should be unchanged.
the tail of a memory log once, preventing possible exponential behavior.
andreistefanescu
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generalize and improve the
asMemAllocationArrayStorecheck.