Add function to check validity and alignment of LLVM pointers #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdockins
reviewed
Jan 28, 2020
| @@ -1738,9 +1764,18 @@ ppMerge vpp c x y = | |||
| where ppAllocList [] = (<+> text "<none>") | |||
| ppAllocList xs = (<$$> indent 2 (vcat $ map vpp xs)) | |||
|
|
|||
| ppAlignment :: Alignment -> Doc | |||
There was a problem hiding this comment.
Nitpick: probably should special case for no particular alignment. Seeing 1-byte-aligned seems like it would b3e pretty confusing, as opposed to no alignment or just nothing at all.
langston-barrett
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function
isAllocatedAlignedPointeris used to to check that an LLVM pointer is valid, points to an allocated region of sufficient size and mutability, and that the pointer meets the required minimum alignment.