Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make truncation-of-weighted-sum rewrite rule more conservative. #363

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Make truncation-of-weighted-sum rewrite rule more conservative. #363

merged 1 commit into from
Dec 5, 2019

Conversation

brianhuffman
Copy link
Contributor

Instead of modifying coefficients in a weighted sum, we now
restrict ourselves to zeroing out coefficients that are equivalent
to zero modulo 2^n.

Fixes #362.

Make truncation-of-weighted-sum rewrite rule more conservative.
561e8a1 
Instead of modifying coefficients in a weighted sum, we now
restrict ourselves to zeroing out coefficients that are equivalent
to zero modulo 2^n.

Fixes #362.
andreistefanescu
andreistefanescu approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@andreistefanescu andreistefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you, @brianhuffman

@brianhuffman brianhuffman merged commit b5ba511 into master Dec 5, 2019
@brianhuffman brianhuffman deleted the issue362 branch December 18, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreistefanescu andreistefanescu andreistefanescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Truncate-of-weighted-sum rewrite is too aggressive
2 participants
@brianhuffman @andreistefanescu