minor fixes #359
Merged
minor fixes #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the SMTLib2 operation `bvudiv`
prove safety conditions as soon as one is disproved.
langston-barrett
approved these changes
Dec 4, 2019
| @@ -537,7 +537,6 @@ class (IsExpr (SymExpr sym), HashableF (SymExpr sym)) => IsExprBuilder sym where | |||
|
|
|||
| -- | Equality of boolean values | |||
| eqPred :: sym -> Pred sym -> Pred sym -> IO (Pred sym) | |||
| eqPred sym x y = notPred sym =<< xorPred sym x y | |||
There was a problem hiding this comment.
What's the problem with this default implementation?
There was a problem hiding this comment.
Nothing, really, but xor is defined as the negation of equality now, and eqPred is actually the primitive that is defined. The only real problem is that the definition is misleading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some minor issues found while working on other things, and add a "fail fast" option to crux that skips attempting to prove further goals once one is disproved