Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CFG.Expr pretty printer to show partial expressions. #339

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

brianhuffman
Copy link
Contributor

The predicate part is still omitted, however.

Fixes #337.

The previous behavior would print WithAssertion expressions as

$17 = withAssertion(BVRepr 64, <some assertion>)

while the new version prints them as

$17 = withAssertion(BVRepr 64, partial($16))

Other than the inclusion of the value expression, I don't have any strong preferences about the syntax. Further bike-shedding would be welcome.

The predicate part is still omitted, however.

Fixes #337.
Copy link
Contributor

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@brianhuffman brianhuffman merged commit 976ad77 into master Nov 12, 2019
@langston-barrett langston-barrett deleted the issue337 branch November 12, 2019 17:12
@robdockins
Copy link
Contributor

If it's easy to do, I'd like to go ahead and also have the predicate be displayed.

@brianhuffman
Copy link
Contributor Author

brianhuffman commented Nov 12, 2019

If the predicate was just a predicate, then it would be easy. However, the predicate part has type AssertionClassifierTree ext e. I'll have to look and see if a pretty printing function exists.

EDIT: It looks like the AssertionTree module does not provide any pretty printing functions. We should probably add one. I'll make a separate ticket for that.

@robdockins
Copy link
Contributor

Oh, yeah, I forgot about that... OK, if it isn't easy to show the predicate, let's at least put a placeholder in the output so people looking at it know that some information has been omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pretty printer for CFG.Expr doesn't show argument to withAssertion
3 participants