Update to use safe nonces #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `globalNonceGenerator` instead of generating new counters. This avoids the potential for mixing nonces from different generators, which has caused a variety of memory safety problems in the past. As a result, fresh handles are created in IO rather than ST. This mostly simplifies things, however, as creating fresh handles was basically always done under `stToIO` anyway.
mostly involves replacing `ST` with `IO` in a variety of places.
This mostly involves replacing ST with IO in various places.
This mostly involves replacing ST with IO in various places
kquick
approved these changes
Jul 17, 2019
| @@ -674,14 +671,9 @@ printSyntaxError (SyntaxError rs) = | |||
| , ", expected ", T.intercalate " or " (nub $ sort [ wanted | Reason _ wanted <- r:more ]) | |||
| , " but got ", toText mempty found] | |||
|
|
|||
| -- | Invoke the default parsing monad on a piece of syntax, returning | |||
| -- the first success found, or the error(s) with the greatest progress | |||
| -- otherwise. | |||
There was a problem hiding this comment.
Should we keep this haddock for syntaxParseIO?
kquick
added a commit
to GaloisInc/macaw
that referenced
this pull request
Jul 19, 2019
Update for compatibility with Crucible changes in GaloisInc/crucible#285.
kquick
added a commit
to GaloisInc/macaw
that referenced
this pull request
Jul 19, 2019
Changes for compatibility with Crucible pull request 285 (GaloisInc/crucible#285) and the corresponding changes in macaw symbolic.
kquick
added a commit
to GaloisInc/macaw
that referenced
this pull request
Jul 19, 2019
Changes for compatibility with Crucible pull request 285 (GaloisInc/crucible#285) and the corresponding changes in macaw symbolic.
kquick
added a commit
to GaloisInc/macaw
that referenced
this pull request
Jul 19, 2019
Changes for compatibility with Crucible pull request 285 (GaloisInc/crucible#285) and the corresponding changes in macaw symbolic.
kquick
added a commit
to GaloisInc/macaw
that referenced
this pull request
Jul 19, 2019
Changes for compatibility with Crucible pull request 285 (GaloisInc/crucible#285) and the corresponding changes in macaw symbolic.
kquick
added a commit
to GaloisInc/renovate
that referenced
this pull request
Jul 22, 2019
Changes for compatibility with Crucible pull request 285 (GaloisInc/crucible#285) and the corresponding changes in macaw symbolic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update changes the
HandleAllocatorto use the global nonce generator fromData.Parameterized.Nonce, instead of creating a fresh nonce counter fromData.Parameterized.Nonce.Unsafe.This changes requires the handle allocation to occur in
IO, which is fine since we are already basically in IO everywhere we needed to be anyway, and this simplifies quite a few things.This PR will require downstream fixes, but they are very straightforward.
Will fix #284