Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix andAlso in LLVMVal testEqual #243

Merged
merged 1 commit into from
May 23, 2019
Merged

Fix andAlso in LLVMVal testEqual #243

merged 1 commit into from
May 23, 2019

Conversation

andreistefanescu
Copy link
Contributor

No description provided.

langston-barrett
langston-barrett approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@langston-barrett langston-barrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@robdockins
Copy link
Contributor

Oy... is there a test case that exposed this bug that we can add to the test suite?

@langston-barrett
Copy link
Contributor

I think the only place this is currently used is in SAWScript.CrucibleOverride.matchArg in the case for SetupGlobalInitializer.

It should be relatively easy to add an artificial test case for, by just creating two concrete LLVMVals and comparing them.

brianhuffman
brianhuffman approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@brianhuffman brianhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andreistefanescu
Copy link
Contributor Author

I was experimenting with this in saw-script when I noticed the bug, but I ended up not using it. I don't see an easy way of adding a unit test.

@andreistefanescu andreistefanescu merged commit 69bf700 into master May 23, 2019
@andreistefanescu andreistefanescu deleted the fix-llvm-val-test-equal branch May 23, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhuffman brianhuffman brianhuffman approved these changes

@langston-barrett langston-barrett langston-barrett approved these changes

@robdockins robdockins Awaiting requested review from robdockins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andreistefanescu @robdockins @langston-barrett @brianhuffman