Make bvConcat rewrites fire more often #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to floating-point comparisons. Fixes #206
kquick
approved these changes
Apr 22, 2019
what4/src/What4/Expr/Builder.hs
Outdated
| bvSum = undefined | ||
| -} | ||
|
|
||
| -- | A slightly more aggressive syntaxtic equality check than testEquality, |
There was a problem hiding this comment.
... aggressive synta c tic equality... collection of known syntax formers.
what4/src/What4/Interface.hs
Outdated
| -- floating point. | ||
| -- compare equal, despite having different bit patterns. | ||
| -- | ||
| -- This test is most appropriate for interpreting the equalty tests of |
point operations.
langston-barrett
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be slightly more aggressive about deciding that terms are equal, so the rewrite rule fires in cases involving floating point casts that arise from LLVM memory model operations.