Fix SMTLib2 syntax for floating-point conversions #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fp.to_sbv` and `fp.to_ubv`.
…lues. These cannot use the ordinary `fresh` construct because the base type underlying the interpreted floating point values is not known at CFG construction time, as it depends on the symbolic backend.
some of the conversions to and from floating point types.
…ntax. It simply appends a newline to the string to be printed.
… if/then/else, show), and improve error messages for float casts that fail type-checking.
proof obligation, and print the result (PROVED, COUNTEREXAMPLE, or UNKNOWN). Fix up the test golden files to match. In addition, add a test exercising floating-point conversions.
|
Shouldn't be anything too controversial in here, I think. |
kquick
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bugfix for SMTLib syntax is contained in 6ee9bcb.
The remainder of this pull request is basically about adding enough support to crucible-syntax and crucible proper to execute a test case verifying the bugfix. This involves adding a syntax for the floating-point types, rounding modes, and a selection of the floating-point cast operations.
Further floating-point operations ought to be easier to add in the future, given this infrastructure.