Export more PartLLVMVal functionality. #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreistefanescu
requested review from
atomb,
brianhuffman,
langston-barrett and
robdockins
langston-barrett
approved these changes
Mar 8, 2019
| @@ -91,6 +91,8 @@ module Lang.Crucible.LLVM.MemModel | |||
| , constToLLVMVal | |||
| , constToLLVMValP | |||
| , ptrMessage | |||
| , Partial.PartLLVMVal | |||
| , pattern Partial.PartLLVMVal | |||
There was a problem hiding this comment.
I would hope that it would be rarely necessary to actually pattern match on a partial value. 90% of the time you should be able to use assertSafe to extract the value. If we find this to be necessary in a bunch of places, we could also consider parameterizing assertSafe over the function that actually makes assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.