Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crucible-llvm-cli: Support for overrides; loading and calling functions #1125

Merged

Conversation

langston-barrett
Copy link
Contributor

@langston-barrett langston-barrett commented Nov 8, 2023

Also exports more low-level helpers from crucible-llvm, suitable for use
without an LLVM module at hand.
@langston-barrett langston-barrett force-pushed the lb/llvm-cli-overrides branch 2 times, most recently from 8fda40b to 9adc57d Compare November 9, 2023 17:49
@langston-barrett
Copy link
Contributor Author

It's possible that this will need a tweak here or there to pass CI, but it's generally ready for review.

Copy link
Contributor

@RyanGlScott RyanGlScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm broadly in favor of this, although I'm definitely feeling the itch for more documentation.

crucible-llvm-cli/test-data/ptr.cbl Show resolved Hide resolved
@langston-barrett
Copy link
Contributor Author

Would you be OK with turning the llvm-pretty Type field into a Maybe Type and adding accompanying documentation stating that it is solely used for error-message purposes? That way, we can pretty-print it if it's available, but we can otherwise ignore it.

Oh yeah, that's a much better idea :)

This is in advance of adding syntax for this operation to crucible-llvm-syntax,
which shouldn't need to use llvm-pretty's AST. This type is only ever used in
diagnostics anyway.
@langston-barrett langston-barrett force-pushed the lb/llvm-cli-overrides branch 2 times, most recently from 736f2e3 to 81c4f9f Compare November 14, 2023 14:35
@langston-barrett langston-barrett merged commit aff9166 into GaloisInc:master Nov 14, 2023
31 checks passed
@langston-barrett langston-barrett deleted the lb/llvm-cli-overrides branch November 14, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants