crucible-llvm-syntax: Concrete syntax for Crucible-LLVM #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will be helpful for crucible-llvm-syntax.
This commit introduces an instance of crucible-syntax's `ParserHooks` for the LLVM language extension. It's far from optimal or complete, but later commits can build on this foundation.
Also, use `ImportQualifiedPost` everywhere
Also, take an LLVM memory global variable as an argument. Not yet necessary, but would be if we were to ever support operations like loading and storing.
langston-barrett
force-pushed
the
lb/crucible-llvm-syntax
branch
from
d19dd07
to
100d1dc
Compare
langston-barrett
force-pushed
the
lb/crucible-llvm-syntax
branch
from
100d1dc
to
7b4c01e
Compare
|
If this is merged, I will make three follow-up issues:
|
kquick
reviewed
Nov 1, 2023
RyanGlScott
approved these changes
Nov 1, 2023
Co-authored-by: Ryan Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MVP implementation of syntax for the LLVM language extension. This package would need additional operations to address the use-cases listed in #920, but provides a reasonable base to start building off. It has the additional benefit of giving an in-repo example of usage of the API introduced in #923.