crucible-syntax: Add support for externs
#1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`extern` is to `defglobal` what `declare` is to `defun`. This patch adds the necessary parts to `crucible-syntax` to parse `extern`s, create fresh `GlobalVar`s for each `extern`, and put them into the `ParsedProgram` API so that callers can insert externs into the `SymGlobalState` with appropriate `RegValue`s. I've included a test case that demonstrates this in action. Fixes #1054.
RyanGlScott
commented
Nov 14, 2022
bboston7
approved these changes
Nov 15, 2022
`Pair TypeRepr` can usually be replaced with `Some`, given that most of the things that `TypeRepr` is paired with (`GlobalVar`, `Atom`, `Reg`, etc.) already store their `TypeRepr` internally. Fixes #1053.
RyanGlScott
added a commit
to GaloisInc/ambient-verifier
that referenced
this pull request
Mar 1, 2023
`extern` is to `defglobal` what `declare` is to `defun`. This patch: * Bumps the `crucible` submodule to bring in the changes from GaloisInc/crucible#1055, which adds support for `extern`s on the `crucible-syntax` side. * Adds the necessary plumbing to the verifier to support the use of `extern`s in function overrides. For the most part, this process is nearly identical to the process used for forward declarations (see `Wrinkle: Externs` in `Note [Resolving forward declarations]` in `Ambient.FunctionOverride.Overrides.ForwardDeclarations`), but perhaps even simpler due to the fact that we do not (yet) have any global variables that are wired directly into the verifier. Fixes #52.
RyanGlScott
added a commit
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
externis todefglobalwhatdeclareis todefun. This patch adds the necessary parts tocrucible-syntaxto parseexterns, create freshGlobalVars for eachextern, and put them into theParsedProgramAPI so that callers can insert externs into theSymGlobalStatewith appropriateRegValues. I've included a test case that demonstrates this in action.Fixes #1054.