Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI for nixos-unstable switch from 9.2.3 to 9.2.4. #1023

Merged
merged 3 commits into from
Aug 9, 2022
Merged

Update CI for nixos-unstable switch from 9.2.3 to 9.2.4. #1023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c42871
Update CI for nixos-unstable switch from 9.2.3 to 9.2.4.
kquick Aug 9, 2022
05ccfd5
Add GHC 9.2.4 freeze file.
kquick Aug 9, 2022
56ec553
Update CI build matrix from GHC 9.2.2 to GHC 9.2.4.
kquick Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/crucible-go-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04]
ghc: ["8.10.7", "9.0.2", "9.2.3"]
ghc: ["8.10.7", "9.0.2", "9.2.4"]
include:
- os: macos-12
ghc: 9.2.2
ghc: 9.2.4
- os: windows-2019
ghc: 9.2.2
ghc: 9.2.4
name: crucible-go - GHC v${{ matrix.ghc }} - ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
GHC=haskell.compiler.ghc$(echo ${{ matrix.ghc }} | sed -e s,\\.,,g)
case ${{ matrix.ghc }} in
9.0.2) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-22.05 ;;
9.2.3) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
9.2.4) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
*) GHC_NIXPKGS=github:nixos/nixpkgs/21.11 ;;
esac
echo NS="nix shell ${GHC_NIXPKGS}#cabal-install ${GHC_NIXPKGS}#${GHC} nixpkgs#gmp nixpkgs#zlib nixpkgs#zlib.dev" >> $GITHUB_ENV
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/crucible-jvm-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04]
ghc: ["8.10.7", "9.0.2", "9.2.3"]
ghc: ["8.10.7", "9.0.2", "9.2.4"]
include:
- os: macos-12
ghc: 9.2.2
ghc: 9.2.4
- os: windows-2019
ghc: 9.2.2
ghc: 9.2.4
name: crucible-jvm - GHC v${{ matrix.ghc }} - ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
GHC=haskell.compiler.ghc$(echo ${{ matrix.ghc }} | sed -e s,\\.,,g)
case ${{ matrix.ghc }} in
9.0.2) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-22.05 ;;
9.2.3) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
9.2.4) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
*) GHC_NIXPKGS=github:nixos/nixpkgs/21.11 ;;
esac
echo NS="nix shell ${GHC_NIXPKGS}#cabal-install ${GHC_NIXPKGS}#${GHC} nixpkgs#gmp nixpkgs#zlib nixpkgs#zlib.dev" >> $GITHUB_ENV
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/crucible-wasm-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04]
ghc: ["8.10.7", "9.0.2", "9.2.3"]
ghc: ["8.10.7", "9.0.2", "9.2.4"]
include:
- os: macos-12
ghc: 9.2.2
ghc: 9.2.4
- os: windows-2019
ghc: 9.2.2
ghc: 9.2.4
name: crucible-wasm - GHC v${{ matrix.ghc }} - ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
GHC=haskell.compiler.ghc$(echo ${{ matrix.ghc }} | sed -e s,\\.,,g)
case ${{ matrix.ghc }} in
9.0.2) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-22.05 ;;
9.2.3) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
9.2.4) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
*) GHC_NIXPKGS=github:nixos/nixpkgs/21.11 ;;
esac
echo NS="nix shell ${GHC_NIXPKGS}#cabal-install ${GHC_NIXPKGS}#${GHC} nixpkgs#gmp nixpkgs#zlib nixpkgs#zlib.dev" >> $GITHUB_ENV
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/crux-llvm-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,16 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04]
ghc: ["8.10.7", "9.0.2", "9.2.3"]
ghc: ["8.10.7", "9.0.2", "9.2.4"]
include:
- os: ubuntu-20.04
ghc: 8.8.4
- os: ubuntu-18.04
ghc: 9.2.2
ghc: 9.2.4
- os: macos-12
ghc: 9.2.2
ghc: 9.2.4
- os: windows-2019
ghc: 9.2.2
ghc: 9.2.4
name: crux-llvm - GHC v${{ matrix.ghc }} - ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
case ${{ matrix.ghc }} in
9.0.2) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-22.05 ;;
9.2.2) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-22.05 ;;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to still keep this line around?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little bit of hoarding instinct: while 9.2 is "in flux", having those historic touchpoints makes me feel safer. I tend to reference CI build processes of various projects as a fairly definitive and explicit way of building things, and so this might be useful to anyone with similar habits that happens to be trying to use 9.2.2 instead of 9.2.4.

That said, there's always git history (although archaeology is not always the easiest way to find information), so there's no really good reason to keep this if you have a strong preference for its removal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I don't feel too strongly about keeping around the configurations for old minor releases—we'll just have to remember to update things like old freeze files.

9.2.3) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
9.2.4) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
*) GHC_NIXPKGS=github:nixos/nixpkgs/21.11 ;;
esac
echo NS="nix shell ${GHC_NIXPKGS}#cabal-install ${GHC_NIXPKGS}#${GHC} nixpkgs#gmp nixpkgs#zlib nixpkgs#zlib.dev" >> $GITHUB_ENV
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/crux-mir-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-20.04]
ghc: ["8.10.7", "9.0.2", "9.2.3"]
ghc: ["8.10.7", "9.0.2", "9.2.4"]
include:
- os: macos-12
ghc: 9.2.2
ghc: 9.2.4
# We want Windows soon, but it doesn't need to be now
name: crux-mir - GHC v${{ matrix.ghc }} - ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -95,7 +95,7 @@ jobs:
GHC=haskell.compiler.ghc$(echo ${{ matrix.ghc }} | sed -e s,\\.,,g)
case ${{ matrix.ghc }} in
9.0.2) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-22.05 ;;
9.2.3) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
9.2.4) GHC_NIXPKGS=github:nixos/nixpkgs/nixos-unstable ;;
*) GHC_NIXPKGS=github:nixos/nixpkgs/21.11 ;;
esac
echo NS="nix shell ${GHC_NIXPKGS}#cabal-install ${GHC_NIXPKGS}#${GHC} nixpkgs#gmp nixpkgs#zlib nixpkgs#zlib.dev" >> $GITHUB_ENV
Expand Down
Loading